Closed meshy closed 7 years ago
@KevinEtienne @Ian-Foote thanks for the feedback guys, but it's probably not worth reviewing this yet, as I'm still working on it, and #75 needs to be merged in first.
I very much appreciate the feedback, BTW :)
Oh, just realised what was going on there... I was asking questions of myself to answer later! Should have known better! Glad to have your answers, and now feel bad for stopping you! :P
Ok, I think I've addressed everything. I've refactored pretty heavily to reduce churn in the history.
@Ian-Foote might I ask for another look and (if you're happy) a 👍?
\o/
Thanks! :)
Deferred from #75:
Route.objects.move_branch(old_url, new_url)
.Route().get_ancestors()
Route().swap_with(other_route, move_children)
Route().move_to(new_url, move_children)
get_ancestors
when called on object that hasn't yet been saved to the database (has nopk
).Trashed ideas:
- [ ] AddRoute.objects.swap_urls(first, second)
method.- [ ] AddRoute.objects.swap_branches(first, second)
method.- [ ] AddRoute().get_parent()