search

meshy / django-conman

NOT READY: Work in progress. A content management system for django
BSD 2-Clause "Simplified" License
3 stars 5 forks source link

Bad tests #9

Closed meshy closed 10 years ago

meshy commented 10 years ago

Bad testing lead to code that wasn't correctly integrated.

meshy commented 10 years ago

A look, please?

meshy commented 10 years ago

Might still be broken.

meshy commented 10 years ago

Should be good to go. Please review/merge.

meshy commented 10 years ago

@Ian-Foote @KevinEtienne wanna look as discussed?

LilyFoote commented 10 years ago

Docstrings.

meshy commented 10 years ago

Docstrings.

For tests?!

LilyFoote commented 10 years ago

Yes. Just a quick summary of what you're testing.

meshy commented 10 years ago

Okay. I'll do the tests from this PR, and I have added https://github.com/incuna/django-conman/issues/11 for the other tests in the project.

mlen108 commented 10 years ago

For tests?!

Docstrings are for code ;]

meshy commented 10 years ago

Do you mind if I do the docstrings in another PR? This one will get too overwhelming with them in, I think.

meshy commented 10 years ago

Thanks