search

meshy / framewirc

An IRC toolkit built upon Python 3's asyncio module
BSD 2-Clause "Simplified" License
35 stars 4 forks source link

Sprinkle a little pytest around #15

Closed ghickman closed 8 years ago

ghickman commented 8 years ago

This adds pytest to the dependencies, switches the runner to pytest and converts some basic test cases as an example usage of pytest.

meshy commented 8 years ago

Thank you! I'll see if I can use this as a base to convert the rest!

meshy commented 8 years ago

https://github.com/meshy/framewirc/commit/f5892e47865f396735edc0dc8c2bb7dbe424df93

meshy commented 8 years ago

Code looks much nicer. Shame they seem to run so much slower as a result.

meshy commented 8 years ago

Granted... they still run in under 3 seconds... :P

LilyFoote commented 8 years ago

Shiny!

ghickman commented 8 years ago

98 passed in 0.56 seconds

I think your counting is wrong :trollface:

meshy commented 8 years ago

I did time make test before and after ;)

ghickman commented 8 years ago

That means you're timing your linting and coverage as well as the tests ;)

meshy commented 8 years ago

They didn't change ;)

meshy commented 8 years ago

...and they are tests :P

meshy commented 8 years ago

Closing in favour of #16