Closed meshy closed 2 years ago
Looks like a good start!
:grin:
I think it needs merging to actually run for the first time, I suggest merging to be able to iterate.
Ah, that explains it. I'll get this merged then -- thanks for the speedy review!
Are you planning on using GitHub Pages as the host or something else?
I was planning on setting up a GitHub Action on a scheduled cron to push to S3, and have Cloudflare in front of it as a CDN. I hadn't considered using GitHub Pages though, so I'll look into that before moving forward. Thanks for the suggestion :)
Here's an example that updates to GitHub Pages on a daily cron:
https://github.com/di/pyreadiness
https://github.com/di/pyreadiness/blob/master/.github/workflows/cron.yml
You can ignore the secrets there, that repo talks to some Google services in its generation step, the commit stuff is all vanilla.
That one commits back to master
. It's also possible to serve GitHub Pages from another branch, but using the default branch is simpler.
Oops -- should have changed the commit to "Continuous Integration" -- oh well!
Here's an example that updates to GitHub Pages on a daily cron
Thanks for the examples. For the moment I think I'm going to continue with the S3 approach, mostly because of familiarity.
If I can get this set up with CI/CD, it should significantly reduce the maintenance burden on me, making it less hassle for me to merge PRs.
In setting this up, I have removed the NPM dependency by switching us over to using the wheel SVG as a favicon.