search

meskarune / i3lock-fancy

i3lock script that takes a screenshot of the desktop, blurs the background and adds a lock icon and text
MIT License
1.52k stars 184 forks source link

Issue with background image colors after blurring #111

Open cjbassi opened 6 years ago

cjbassi commented 6 years ago

Some colors become much darker when blurred and also some colors become completely altered. I'm curious if anyone else has these issues but I could post pics if needed. For an example of the darkening, white backgrounds seem to be okay overall like in the example gif in the README, but if you use the locker on this image, it becomes more noticeable. And color changing issues are noticeable here. I assume this is an issue with imagemagick but I thought I would start here.

PandorasFox commented 6 years ago

I believe that's a general problem with some sorts of hardware-accelerated blurs and it's one of the tradeoffs with speed vs accuracy, but I might be misremembering.

meskarune commented 6 years ago

I will have a look and try to test. Right now the script darkens using transparent black when the background is above a certain brightness threshold, then blurs. Maybe the order of steps needs to change or maybe it is an issue with image magick and blurring in general.

alimoabd2127 commented 6 years ago

I have this issue as well and can provide some examples. Here are the locked and unlocked images.

meskarune commented 6 years ago

The script is supposed to darken the background when it blurs, so that is intentional, but it wouldn't be normal if there are major color changes like purple to blue for example.