Closed nvladimus closed 4 years ago
Awesome - I can get it to work, but I ran into an additional issue:
File "h5py/h5g.pyx", line 161, in h5py.h5g.create ValueError: Unable to create group (name already exists)
error message - it seems to me that currently, no tile count is present. A while ago, I've implemented a simple tile count as the generate_tiledict
method here.Minor things:
mesoSPIM_ImageWriter.py
has a lot of diagnostic print statements - I'm trying to slowly get away from them (mea culpa, see above)- btw: you can use logger.info('Put your info here')
instead.tmp
directory seems to be missing - I wanted to keep it (and the small .txt
in it) as a good default save location for demodata that works out of the box.Questions for you:
~.h5
, one option is to turn this into another option in the Filename Wizard?shutter = Both
? - People should be discouraged from using it, but there might be the need for a warning.Thanks for your feedback, @ffvoigt. Here are some major changes ✌️ tiling is added and seems to work. ✨ tiles contain positional information (XYZ) - which places them on a 3D grid in BigStitcher. Each tile also knows its voxel size.
Minor things:
/tmp
directory to git .ignore list, using it for my own debugging purposes, sorry for confusion.To you questions,
.raw
or .h5
shutter = Both
is handled as illumination setting No.3, this is not a problem for BigStitcher. Whether user wants/needs it, is another question. Since it's already there, I see no reasons to remove it. Maybe useful e.g for some tricky alignment situations.So, changes are merged - Thanks -but there is still some weirdness going on: When dealing with a demo dataset with 1.6 micron pixel size, Bigdataviewer displays it as 1024 pixels across and not 1638 µm. As a result, a tiled dataset suddenly has gaps even though the overlap is correct. This might be an issue with the order of transformations in the XML or with the units of affine matrix transformation in the XML.
Also, I've added single h5 support in the filename wizard, I don't know whether having another option for all the files is a good idea, but I will think about it.
Good catch - I forgot that transformation coordinates are in px, not um. Fixed, will submit new PR now.
Hi, I implemented writing of multiple rows into a single H5 file that contains rows as views grouped by:
Remaining issue: when a row contains new rotation, the image writer does not finalize XML file. Maybe because rotation not implemented in Demo mode? Not sure.