mesoSPIM / mesoSPIM-control

Image acquisition software for mesoSPIM light-sheet microscopes.
http://www.mesospim.org
GNU General Public License v3.0
37 stars 12 forks source link

functional writing into BigDataViewer/BigStitcher HDF5 #38

Closed nvladimus closed 4 years ago

nvladimus commented 4 years ago

Hi, I implemented writing of multiple rows into a single H5 file that contains rows as views grouped by:

Remaining issue: when a row contains new rotation, the image writer does not finalize XML file. Maybe because rotation not implemented in Demo mode? Not sure.

ffvoigt commented 4 years ago

Awesome - I can get it to work, but I ran into an additional issue:

Minor things:

Questions for you:

nvladimus commented 4 years ago

Thanks for your feedback, @ffvoigt. Here are some major changes ✌️ tiling is added and seems to work. ✨ tiles contain positional information (XYZ) - which places them on a 3D grid in BigStitcher. Each tile also knows its voxel size.

Minor things:

To you questions,

ffvoigt commented 4 years ago

So, changes are merged - Thanks -but there is still some weirdness going on: When dealing with a demo dataset with 1.6 micron pixel size, Bigdataviewer displays it as 1024 pixels across and not 1638 µm. As a result, a tiled dataset suddenly has gaps even though the overlap is correct. This might be an issue with the order of transformations in the XML or with the units of affine matrix transformation in the XML.

Also, I've added single h5 support in the filename wizard, I don't know whether having another option for all the files is a good idea, but I will think about it.

nvladimus commented 4 years ago

Good catch - I forgot that transformation coordinates are in px, not um. Fixed, will submit new PR now.