mesoSPIM / mesoSPIM-control

Image acquisition software for mesoSPIM light-sheet microscopes.
http://www.mesospim.org
GNU General Public License v3.0
35 stars 11 forks source link

Do not write duplicate data z_stepsize and z_planes data in metadata. #70

Closed raacampbell closed 1 year ago

raacampbell commented 1 year ago

I don't know if there was a reason for this, but there are two duplicate lines being written to meta-data files. Since it can potentially cause confusion reading back these data, I suggest removing them. I add a second commit that removes the : in [Frame rate:], as no other keys have this.

raacampbell commented 1 year ago

Also, is there a reason there are square brackets around everything?

[Metadata for file] D:/Peter/22-11-02 EZ cfos tdtom/08X_front_EZ_cfostdtom_Tile0_Ch561_Sh0.tiff
[z_stepsize] 10
[z_planes] 999

[CFG] 
[Laser] 561 nm
[Intensity (%)] 40
[Zoom] 0.8x
[Pixelsize in um] 8.23
[Filter] 405-488-561-640-Quadrupleblock
[Shutter] Both

[POSITION] 
[x_pos] 30749.83
[y_pos] 63999.91
[f_start] 48900.0
[f_end] 48900.0
[z_start] 20550.05
[z_end] 30549.92
[z_stepsize] 10
[z_planes] 999
[rot] 356.5

[ETL PARAMETERS] 
[ETL CFG File] config/etl_parameters/ETL-parameters_SWC.csv
[etl_l_offset] 1.64
[etl_l_amplitude] 1.4
[etl_r_offset] 1.448
[etl_r_amplitude] 1.264

INI file readers consider square brackets to mean the start of a section and so they treat each key as section. I guess it is because this is not really an INI file? No = but uses [] instead?

nvladimus commented 1 year ago

Hi, Rob, Good point about the duplicate entries, I merged it, thank you. Regarding the brackets use, this is not an INI file, but a custom file format made by Fabian. I'd keep it as it to avoid breaking people's pipelines of parameter parsing. I hope that's OK.

I'd also suggest to pull requests to development branch, so things can be tested on hardware before making into a release. Thanks for your contributions!