search

mesoSPIM / mesoSPIM-control

Image acquisition software for mesoSPIM light-sheet microscopes.
http://www.mesospim.org
GNU General Public License v3.0
37 stars 12 forks source link

Disable buttons and spinboxes for the opposite light-sheet during ETL parameter optimization #71

Closed ffvoigt closed 1 year ago

ffvoigt commented 1 year ago

When training new mesoSPIM users, I noted that they often start by: 1) Trying to optimize ETL parameters for the opposite light-sheet and don't realize that the image is not changing 2) Changing the ETL amplitude after toggling the AmpL/R=0 buttons 3) Overwriting the ETL amplitude in the config file after toggling the AmpL/R=0 buttons by hitting the save button at the wrong time.

With experience, they stop doing this - but this is highly confusing for beginners. To avoid this source of frustration, this commit adds code to disable the relevant ETL parameter buttons for the opposite light-sheet. I've also tried to make sure that this works when a mesoSPIM is configured to allow both illumination directions.

nvladimus commented 1 year ago

Hi, Fabian, Many thanks for PR! I am on holidays until Jan 3, and test/merge it to development branch as soon as I am back. Will be included in the next release of master!

ffvoigt commented 1 year ago

Hi,

Should I do another pull request to the development branch then?

Have a great holiday break!

Fabian

nvladimus commented 1 year ago

No worries, I will review it and merge to development. Happy holidays!

nvladimus commented 1 year ago

Merged into Development.