search

mesonbuild / meson-python

Meson PEP 517 Python build backend
https://mesonbuild.com/meson-python/
MIT License
120 stars 59 forks source link

CI: update codecov action #479

Closed dnicolodi closed 10 months ago

dnicolodi commented 10 months ago

@rgommers Do you know anything about the integration of codecov into the github project? I think that as we upload the coverage reports to codecov we may as well have codecov report back the coverage report as a status check on the pull requests. However, the status checks do not appear. I've been reading the codecov documentation. AFAIU, status checks should be enabled by default

rgommers commented 10 months ago

It used to appear in status checks, see e.g. https://github.com/mesonbuild/meson-python/pull/165#issuecomment-1271509356. That also discusses informational: true. Codecov status checks are somewhat useful indeed on occasion, as long as their bot doesn't comment and it never fails.

It looks like it disappeared when we migrated the repo to the mesonbuild org. The GitHub App isn't installed on this repo. The status checks are visible on Meson PRs, so I don't think there's a security concern with it (despite Codecov not exactly being the most reliable provider - multiple security issues).

I don't have permissions to install the App, but I was able to send a request for it - once it's approved by a mesonbuild org admin the problem should be fixed.

dnicolodi commented 10 months ago

Thanks @rgommers

dnicolodi commented 10 months ago

I wanted to make sure that the codecov reports are sensible before merging. But we can tweak the configuration further later, if needed.

rgommers commented 10 months ago

Yeah, I figured this is almost certainly right, and the cleanups are useful. We can tweak it later if needed.