search

mesonbuild / meson-python

Meson PEP 517 Python build backend
https://mesonbuild.com/meson-python/
MIT License
120 stars 59 forks source link

Incorrect package name in `METADATA` #481

Closed dnicolodi closed 9 months ago

dnicolodi commented 10 months ago

Looking into more simplifications, on the line of the first commits in #480, I bumped into this issue https://github.com/FFY00/python-pyproject-metadata/issues/60 Some more context is here https://github.com/pdm-project/pdm-backend/issues/185 and here https://discuss.python.org/t/change-in-pypi-upload-behavior-intentional-accidental-pebkac/27707 The latter is a very long thread and I didn't even attempt to read it all.

We can fix this bug on the meson-python side, but it would be much easier to do once #480 lands.

dnicolodi commented 10 months ago

A related issue is that there is no validation of the package name. The allowed names are defined here https://packaging.python.org/en/latest/specifications/core-metadata/#name

rgommers commented 9 months ago

The latter is a very long thread and I didn't even attempt to read it all.

Ouch. Yes, definitely not reading an 84 message thread on what should be a simple thing one would think. Reviewing your PR now.

rgommers commented 9 months ago

Both package name handling and validation are fixed/implemented in gh-483, so closing.