search

mesonbuild / meson-python

Meson PEP 517 Python build backend
https://mesonbuild.com/meson-python/
MIT License
126 stars 65 forks source link

TST: remove pep518 tests #493

Closed dnicolodi closed 1 year ago

dnicolodi commented 1 year ago

These tests verify that build can build sdists and wheels using meson-python. The pep518 name is misleading as meson-python itself does not implement PEP 518. These tests verify that the PEP 517 hooks exported by meson-python work as build expects them to work.

These tests setup a local directory with wheel for the build dependencies. This is problematic for two reasons: it requires network access, thus distributions need to disable these tests with downstream patches, and it makes it very difficult to run the tests against a specific version of meson.

Creation of wheels and sdists is tested as part of the unit tests. The pep517 tests are unit tests for some of the PEP 517 hooks. The installation of meson-python itself in the CI jobs works as integration tests.

Remove these tests.

dnicolodi commented 1 year ago

Thanks. This became a pain when testing on Python 3.12 and trying to make the setuptools dependency conditional to the meson version and testing the changes in meson to do not require setuptools.