search

mesonbuild / meson-python

Meson PEP 517 Python build backend
https://mesonbuild.com/meson-python/
MIT License
118 stars 59 forks source link

ENH: no output in editable verbose mode when there is no work to do #594

Closed dnicolodi closed 2 months ago

lesteve commented 3 months ago

I had a quick look and it looks good, thanks for this!

I had some small changes on top of #579 but it looks like your changes are simpler.

dnicolodi commented 3 months ago

I extended the tests further and improved the log message. I think logging the package name instead of the top level module names is much better. It requires passing one more argument to the loader instance, but I don't see any draw back in doing so.

lesteve commented 3 months ago

This one seems ready to be merged, cc @rgommers. Let me know is someone else is likely to review!

Once this PR is merged it would be great if a release of meson-python could be made. There is not a huge rush, but together with https://github.com/mesonbuild/meson-python/pull/569 this would make it easier for scikit-learn to transition to Meson as our main build backend, see https://github.com/scikit-learn/scikit-learn/pull/28506 for more details.

dnicolodi commented 3 months ago

The unwritten policy is that "significant" PRs by project maintainers need review by another maintainer. I suspect @rgommers is very busy with the upcoming NumPy 2.0 release. This is not a critical bug fix (from our point of view, at least), thus you'll need to be patient for a bit longer 🙂

lesteve commented 3 months ago

Thanks for your answer, and indeed I completely understand that people have other priorities (I should have been more explicit about this in my previous message) !

dnicolodi commented 2 months ago

@rgommers After thinking a bit more abut it, I'll be merging this PR before releasing 0.16.0. Unless you object, I'll be doing this before the end of the week.

lesteve commented 2 months ago

Great to see this one merged, thanks :tada: