search

mesonbuild / meson-python

Meson PEP 517 Python build backend
https://mesonbuild.com/meson-python/
MIT License
118 stars 59 forks source link

DOC: add docs on using the `build-dir` config setting #616

Closed rgommers closed 1 month ago

rgommers commented 2 months ago

Closes gh-540

Also touches on gh-246, which is a common enough hiccup that it's useful to explicitly show dealing with meson-log.txt in CI.

rgommers commented 1 month ago

Addressed all comments, I think this is ready now.

rgommers commented 1 month ago

Cirrus is not happy. Can be ignored for this PR, since its docs-only.

dnicolodi commented 1 month ago

@rgommers I find fixing prose via GitHub reviews not very efficient. I edited your text to make it flow better and pushed it to your branch. No conceptual changes intended. Please have a look.

henryiii commented 1 month ago

We could change the other places that have a pip version to use -C now, I think? (Not in this PR!)

rgommers commented 1 month ago

We could change the other places that have a pip version to use -C now, I think? (Not in this PR!)

Agreed.

rgommers commented 1 month ago

The rephrasings LGTM - time to get this in. Thanks @dnicolodi and @henryiii