search

mesonbuild / meson-python

Meson PEP 517 Python build backend
https://mesonbuild.com/meson-python/
MIT License
128 stars 66 forks source link

`test_reproducible` fails #695

Closed mtelka closed 1 hour ago

mtelka commented 3 hours ago

I'm running tests from meson-python 0.17.0 sdist and I found that the test_reproducible test fails with this message:

+ meson dist --allow-dirty --no-tests --formats gztar
Dist currently only works with Git or Mercurial repos

It looks like the test expects it is run from the git repo and not from sdist.

dnicolodi commented 2 hours ago

The test does not try to create an sdist for the meson-python package itself. It uses a temporary git reposiotry that is created on demand for executing the test. Therefore, it does not matter whether the test is executed from a git checkout or from the uncompressed sdist. There are other tests that have similar requirements, thus if only this test is failing something else is likely wrong. Can you please report the complete test log?

dnicolodi commented 2 hours ago

Oh. I just checked, and indeed the test setup for that particular test is wrong. Sorry for the noise. I'm preparing a fix

mtelka commented 2 hours ago

I'm glad to see that you are faster with the root causing and fixing than me with providing the log :-).

dnicolodi commented 2 hours ago

Thank you for the report!

dnicolodi commented 1 hour ago

I merged the fix. I verified locally that is solves the issue you reported. Unless the failing test causes major downstream issues, I don't think that we will be doing a bugfix release to fix just this. Please let me know if this is a problem.

mtelka commented 1 hour ago

Thank you for the fix. It is not a problem at all. I just deselected this single test and so I do not need new release.