search

mesonbuild / meson

The Meson Build System
http://mesonbuild.com
Apache License 2.0
5.3k stars 1.52k forks source link

Python: Fix limited API under mingw #13171

Open amcn opened 2 weeks ago

amcn commented 2 weeks ago

Link to the correct Python limited API DLL under mingw

This aims to fix #13167

amcn commented 2 weeks ago

Disappointingly the tests seem to have all passed which makes me think we are missing something which tests precisely whether the right library was linked or not by shelling out to ldd/dumpbin/otool.

I'm going to add that now into unittests/pythontests (where I should have added such a test in the initial limited api submission now that I think about it).

lpsinger commented 2 weeks ago

I find that this PR fixes the issue: https://github.com/nasa-gcn/hpx/pull/21

amcn commented 1 week ago

I've reworked this PR to do two things:

  1. Tests have been updated: a new unittest has been added (for windows only), and the existing limited API test has been extended with an extra section to load the built module.
  2. The original fix has been split into two commits: one to move the code that has to be moved, and a second to implement the fix.

Hopefully this is easier to review now. Feedback very welcome.