search

mesonbuild / meson

The Meson Build System
http://mesonbuild.com
Apache License 2.0
5.33k stars 1.53k forks source link

Does meson discourage outside contributors? #13210

Closed gabeblack closed 2 weeks ago

gabeblack commented 2 weeks ago

I took time to contribute this feature: https://github.com/mesonbuild/meson/pull/13035 which had indication in other threads of being something that might be desired.

However, the radio silence has turned me off to making further contributions. The general Q/A forum here seems to get responses which I am very appreciative -- however, I'm surprised that those that want to contribute back are ignored.

Did I miss a procedure when trying to contribute back? Or are outside contributors discouraged from contributing? Or something else?

thesamesam commented 2 weeks ago

No, meson doesn't discourage outside contributors. It just doesn't have many reviewers. You're encouraged to ping. Doing so on IRC / Matrix can help too.

It's also obviously harder to find time to review API changes because they're a commitment.

I also know that a few people were away a fair amount over the last month, which makes the reviewer situation worse.

All this said, don't get me wrong, I understand wanting PRs merged, but I make a lot to various projects and I've never felt inclined to file a bug asking if people are ignoring my PRs after just a month either. I do think Meson does tend to suffer a bit from forgetting PRs but it's not at all an institutional or a policy thing, just people being people and getting overloaded.

gabeblack commented 2 weeks ago

I did ping a couple of times. No matter though -- because I didn't know that waiting more than a month for a response is normal. I do have a day-job and a family, so trying to keep that thread/fork alive and up-to-date over the period of multiple months is probably not something I'm willing to do and maintain. I do appreciate the project and was hoping to contribute when I can. However, I don't think my current work/life balance allows for such a long dev/contribution cycle. No biggie. Again, I appreciate your reply to my inquiry and I appreciate the meson project in general.

I'll close this issue as well as my PR request as to not clutter your issues/merge requests forum. Again thank you.

thesamesam commented 2 weeks ago

I understand. It's not always easy to page in all the context from months ago and so on. I agree the review situation could be a lot better..

mid-kid commented 1 week ago

You don't need to "maintain" a fork - if the changes are approved, it can be updated then for the sake of merging.