Open arcondello opened 3 weeks ago
Meson doesn't have a "null" type, and hence cannot use it to signal "should not use this kwarg". IIRC my original assumption was indeed that people would specify gnu_symbol_visibility: 'default'
.
Would there be interest in adding an explicit 'unset'
option? I'd be happy to take a crack at the PR. If not, I think 'default'
should be OK for us and this issue can be closed. Thanks!
Describe the bug
Explicitly setting
gnu_symbol_visibility: ''
gets interpreted asgnu_symbol_visibility: 'hidden'
for Pythonextension_modules
.This is because an empty string gets overriden by
hidden
, presumably to change the defaulthttps://github.com/mesonbuild/meson/blob/42a4d1aaa0854d376e9d28cf4b6ca93df90c8213/mesonbuild/modules/python.py#L229
To Reproduce
Should be reproducible easily with
For the originating example, compare https://github.com/dwavesystems/dwave-optimization/pull/90/commits/21958780b5745634edee2aedb85930f18f0e5bd1 https://github.com/dwavesystems/dwave-optimization/pull/90/commits/1451e26d5e6eb653e4507e06300800d893c13986
The former gives (for macos builds on CircleCI)
whereas the latter gives
Expected behavior
It would be nice to have some way to explicitly specify unset. Though I can use
'default'
for now.system parameters