search

mesonbuild / meson

The Meson Build System
http://mesonbuild.com
Apache License 2.0
5.64k stars 1.64k forks source link

Reimplement auto pull of wraps downloaded by vcs as documented. #4395

Open textshell opened 6 years ago

textshell commented 6 years ago

In #4327 the auto pull of wraps from VCS was removed in refactoring, because it was broken in many cases.

@jpakkane decided that the next step is to reimplement it according to the documentation and do potential later improvements after restoring the documented behavior.

The documentation is in http://mesonbuild.com/Wrap-dependency-system-manual.html#branching-subprojects-directly-from-git

See also the similar description for hg and svn.

The last version of the partially broken implementation is in https://github.com/mesonbuild/meson/blob/67cc636e5375dae03fb43807d2c5222b8c78910c/mesonbuild/wrap/wrap.py

xclaesse commented 6 years ago

I personally think it is a bad idea to start pulling new code in the middle of the build process. If we really want to restore this feature, make sure to only do it when revision=head, unlike previous code that was trying to do it on any value of revision.

IMHO, we should remove that part of the doc and merge PR #4389 instead.