search

mesonbuild / meson

The Meson Build System
http://mesonbuild.com
Apache License 2.0
5.63k stars 1.63k forks source link

Non existing wxWidgets modules are still found #5074

Open jhasse opened 5 years ago

jhasse commented 5 years ago

Doing

dependency('wxwidgets', version : '>=3.0.3', modules : ['anything_can_go_here'])

succeeds but results in a linker error later:

/usr/bin/ld: cannot find -lwx_gtk3u_anything_can_go_here-3.0

As I want to check, if a specific module is available, the check should probably also test if wx-config's result actually compiles.

nirbheek commented 5 years ago

Would you like to work on a fix for this? The work is confined to mesonbuild/dependencies/ui.py:WxDependency. Before setting self.compile_args and self.link_args, check if that actually works. Other dependency classes use self.clib_compiler to find libraries, you can use something similar.

jhasse commented 5 years ago

Yes, I'll have a look, thx :)

Btw: While we're at it, can you reopen #1423? I'd like to work on a fix for that issue, too, see my comment: https://github.com/mesonbuild/meson/issues/1423#issuecomment-411410129