search

mesonbuild / mesonwrap

Meson wraps service and tools, please use https://github.com/mesonbuild/wrapdb for wraps issues
https://wrapdb.mesonbuild.com
Apache License 2.0
26 stars 7 forks source link

New wrap: lz4 #103

Closed jcaesar closed 5 years ago

jcaesar commented 5 years ago

Version: 1.9.1 License: BSD 2-clause Url: https://github.com/lz4/lz4/ Name: lz4

Preview: https://github.com/jcaesar/crappywraps/tree/master/lz4

jcaesar commented 5 years ago

Argh. I just realized, lz4 already contains a meson build file since 1.9.0, and the one I've written is entirely unnecessary.

Now I'm unsure what to do.

[Edit:] After talking to @nirbheek on irc, it seems that the cleanest way would be to add a meson-build-subdir = option to wrap files (since the provided one requires an option.txt).

The wrap file provided by upstream also has some not so nice parts, so it may need patching anyway.

DEPRECATION: Option uses prefix "build_", which is reserved for Meson. This will become an error in the future.

Hence, I'll keep my wrap file and this open request for now.

jcaesar commented 5 years ago

@sarum9in any comments?

sarum9in commented 5 years ago

What about adding a root meson.build file and importing existing file from it via subdir()?

https://mesonbuild.com/Reference-manual.html#subdir

jcaesar commented 5 years ago

Any neat way of dealing with the options file, which is also in a subdirectory? (If in doubt, I can duplicate it.)

sarum9in commented 5 years ago

I don't have any good ideas. We should implement subdir option as was suggested I suppose. Let's just copy it for now.

jcaesar commented 5 years ago

To get this finally done…

https://github.com/jcaesar/crappywraps/blob/13/lz4/lz4.wrap

I've also received permission to move the meson build files to a different folder upstream, so for future releases of lz4, only a single meson.build and meson_options.txt need to be included in the patch file.

sarum9in commented 5 years ago

https://github.com/mesonbuild/lz4