search

mesonbuild / mesonwrap

Meson wraps service and tools, please use https://github.com/mesonbuild/wrapdb for wraps issues
https://wrapdb.mesonbuild.com
Apache License 2.0
26 stars 7 forks source link

nlohmann_json: duplication and heavy tarball #76

Closed mpoquet closed 5 years ago

mpoquet commented 5 years ago

Hello,

I am a new Meson user and I would like to add a wrap for the nlohmann/json library.

Duplication

I saw that the library is already wrapped under the json name there on Wrap DB but also under the nlohmann_json name there on Wrap DB. Is this intentional?

Downloaded files are a thousand time heavier than needed

The wraps of the two existing repos download the full source tarball of 110 MB, which could be avoided since the project maintainer provides an includable tarball of ~130 KB.

I successfully could retrieve the latest release include zip and apply this (standard) patch to get a Nix package of the library (by calling Meson).

sarum9in commented 5 years ago

Duplication

The json package has a comment in the description deprecated: use nlohmann_json. It was poorly named and kept for backward compatibility.

The wraps of the two existing repos download the full source tarball of 110 MB, which could be avoided since the project maintainer provides an includable tarball of ~130 KB.

That is up for maintainers. Patches are welcome, I have no idea about individual wraps. You can check pull request history to find wrap maintainers.

mpoquet commented 5 years ago

Thanks for the quick reply!

I submitted a pull request to mesonbuild/nlohmann_json there.

sarum9in commented 5 years ago

Thank you. Just FYI I get notification for all pull requests and new issues in all wrap repositories. :)