search

mesonbuild / mesonwrap

Meson wraps service and tools, please use https://github.com/mesonbuild/wrapdb for wraps issues
https://wrapdb.mesonbuild.com
Apache License 2.0
26 stars 7 forks source link

new wrap: benchmark #78

Closed jeandet closed 5 years ago

jeandet commented 5 years ago

upstream url: https://github.com/google/benchmark version: 1.4.1

sarum9in commented 5 years ago

I am a bit hesitant to name the wrap "benchmark" as it is a really broad term. Have you considered "googlebenchmark" instead? Is it widely used as "benchmark" and uniquely identifies it?

dcbaker commented 5 years ago

Since we call "google test" "gtest", maybe it makes sense to call this "gbenchmark"? Just a though.

jeandet commented 5 years ago

@sarum9in @dcbaker google test is not named just Test but googletest or gtest while benchmark is never named upstream google benchmark or gbenchmark, so I don't know what is better. Benchmark is a shitty name...(funny for a company who knows search engines)

jpakkane commented 5 years ago

funny for a company who knows search engines

Would that be the same company who created a programming language named "Go"? :P

sarum9in commented 5 years ago

I think we should make it as a policy for wraps to not introduce generic names for these cases and use google-benchmark, similar to https://github.com/mesonbuild/microsoft-gsl

Any objections?

jeandet commented 5 years ago

@sarum9in I'm OK with this. So the generated dependency will be google_benchmark_dep. BTW I wasn't able to call the library 'benchmark' because it would add a target named 'benchmark' in the ninja file which is already used by Meson... https://github.com/jeandet/benchmark/blob/mesonbuild/meson.build#L31

sarum9in commented 5 years ago

https://github.com/mesonbuild/google-benchmark