search

mesonbuild / vscode-meson

Meson for VisualStudio Code
Apache License 2.0
108 stars 50 forks source link

WIP: run all tests button and context menus #191

Open lukester1975 opened 1 year ago

lukester1975 commented 1 year ago

First commit is the run/run all buttons in the meson view.

Second commit adds context menus all over the shop. Makes more sense on my old multiple builddir branch (e.g. I had hacked a very unpleasant debug command, but given the debug provider stuff, doesn't seem worth it unless that can be hooked in to; haven't looked), but maybe worth adding some now.

Personally, I don't like that clicking on a target builds it. Could add an inline button next to the open meson.build and just leave clicking on the node to expand it.

Also moves the reconfigure button (if/when multiple root/builddirs are added, it doesn't make sense to have a reconfigure button in the sidebar's header).

Build icon came from the cmake plugin. Whether that would need attribution somewhere I've no idea...

Cheers

lukester1975 commented 12 months ago

run build

I put back the header configure button as if there's no build dir, there would be no configure button... Was different with the multiple build dir support as there was a project-level node, with build dirs beneath it.

tristan957 commented 12 months ago

This looks solid to me. Are you ready to go?

lukester1975 commented 12 months ago

Two things:

  1. Personally, I don't like that clicking on a target builds it. Could add an inline button next to the open meson.build and just leave clicking on the node to expand it.

Feels like nowhere else in the ui does clicking on a non-leaf node not expand it. But maybe there's precedent elsewhere...

  1. build icon attribution. I couldn't see anything in the cmake repo.

Cheers

tristan957 commented 12 months ago

I agree with you on 1. If you want to add a build button, I think that would be a great addition!

Did you get the icons from the CMake or CMake Tools extension?

lukester1975 commented 12 months ago
  1. OK. Might get to it later.

It was cmake tools.

lukester1975 commented 12 months ago

OK added a commit with that change.

I need to take a look at the icon though. It's ugly when hovering over a selected target node (OK with dark theme):

ugly

lukester1975 commented 11 months ago

BTW, icon is ugly in cmake plugin too.

Dark mode is fine.