search

mesonbuild / vscode-meson

Meson for VisualStudio Code
Apache License 2.0
99 stars 49 forks source link

Run Task: Use DevEnv #221

Open CyborgPotato opened 3 months ago

CyborgPotato commented 3 months ago

Run Task fails on Windows occasionally due to error 87 in creating process, this can be avoided, and manually entering env can be avoided by instead running the executable via meson's devenv

tristan957 commented 3 months ago

@xclaesse can you take a look at this and give it some thought? Seems like a good idea.

CyborgPotato commented 2 months ago

@tristan957 @xclaesse Just wanting to check in if any opinion on this change

tristan957 commented 2 months ago

I'm sorry for letting this sit, and I will try to get to it as soon as I can. Can you fix the CI while you're here?

CyborgPotato commented 2 months ago

@tristan957 Of course, i fixed the prettier issue and have rebased my fork. Thanks again for considering the PR

xclaesse commented 2 months ago

The intention is clearly to run those exe in devenv, I'm not sure why I haven't done it your way in the first place. Loading the generated env file into a dict seems weird in retrospect. LGTM.

tristan957 commented 2 months ago

@xclaesse I'll let you hit the merge button when you're happy.