libscpi: new wrap - Githubissues

mesonbuild / wrapdb

New wrap requests

https://mesonbuild.com/Adding-new-projects-to-wrapdb.html

MIT License

72 stars 187 forks source link

libscpi: new wrap #1471

Open jakergrossman opened 4 months ago

jakergrossman commented 4 months ago

Does this repository squash PRs? I couldn't find the answer.

jpakkane commented 4 months ago

A single commit is preferred unless the MR changes a lot of things.

jakergrossman commented 2 months ago

Removed examples from wrap
Removed hand-added compiler flags
Squashed to a single commit

benoit-pierre commented 2 months ago

Removed examples from wrap

Why? Assuming they only the use the public API, those are a good way to check the resulting shared library or DLL export all the required symbols.

jakergrossman commented 2 months ago

Removed examples from wrap

Why? Assuming they only the use the public API, those are a good way to check the resulting shared library or DLL export all the required symbols.

I think I was having issues with the TCP examples, but I just added them back guarded them with a header check for 'netinet/in.h' for those two examples.

jakergrossman commented 2 months ago

Tested with the following in the root of wrapdb:

rm -rf builddir &&
meson subprojects purge --confirm &&
meson setup builddir/ -Dwraps=libscpi --default-library=shared &&
meson compile -C builddir -v &&
meson test -C builddir