mesonbuild / wrapdb

New wrap requests
https://mesonbuild.com/Adding-new-projects-to-wrapdb.html
MIT License
69 stars 176 forks source link

zstd: don't add `-pthread` to static linking flags on Windows #1484

Closed bgilbert closed 2 months ago

bgilbert commented 2 months ago

Meson always returns -pthread in dependency('threads') on non-MSVC compilers. On Windows, zstd uses Windows threading primitives, so we don't need this. Avoid adding -pthread to libzstd's link flags, either as a Meson subproject or via pkg-config Libs.private, so the application doesn't inadvertently depend on winpthreads.

Merged upstream in https://github.com/facebook/zstd/pull/3931.

eli-schwartz commented 2 months ago

Thanks!