search

mesonbuild / wrapdb

New wrap requests
https://mesonbuild.com/Adding-new-projects-to-wrapdb.html
MIT License
77 stars 195 forks source link

Fix soundtouch pkg-config include paths #1498

Closed neodesys closed 5 months ago

neodesys commented 5 months ago

When built with autotools or cmake, the libsoundtouch project defines the path '-I${includedir}/soundtouch' in its .pc file. This is the same path that is also used in Ubuntu and Fedora Linux distributions packages. This patch adds this path to the .pc file generated by the meson project.

tp-m commented 5 months ago

cc @amyspark @nirbheek

dcbaker commented 5 months ago

Does upstream only put the soundtouch/ subdir in, or does it do both? We should match what upstream does

neodesys commented 5 months ago

The libsoundtouch project only specifies the -I${includedir}/soundtouch path and nothing more. But I think it may be fair to specify both paths in case that some projects have been using this wrap file with the previous wrong path.

https://codeberg.org/soundtouch/soundtouch/src/branch/master/soundtouch.pc.in

dcbaker commented 5 months ago

Maybe others have a different opinion, but I don't think we should keep doing something that upstream doesn't do. The point of these is to match their behavior, not invent our own.

neodesys commented 5 months ago

:+1: if the default behavior is to always keep the upstream project default, we should stick to it. I've updated the PR.