glfw: add version 3.3.10

[QWERTIOX]

I don't know why it says during generation that this is still 3.3.9

[benoit-pierre]

I don't know why it says during generation that this is still 3.3.9

You need to update subprojects/packagefiles/glfw/meson.build too.

[benoit-pierre]

And 3.4 has a number of changes to the CMake build system, you need to review those and update the meson port in subprojects/packagefiles/glfw accordingly.

[QWERTIOX]

thanks, by accident i also pushed commit to add 3.4 in same pr and i don't know how to remove it

[QWERTIOX]

So i need also to update libxml2?

[jpakkane]

No, it has been updated in master between you filing this MR and the test starting to run.

[QWERTIOX]

can someone run sanity checks again then?

[benoit-pierre]

Just close and re-open this PR. Or rebase and force push.

[benoit-pierre]

In any case, someone also need to approve the workflow, again, @jpakkane?

[eli-schwartz]

Please squash the commits or revert to only the first commit. :)

[benoit-pierre]

Stop, go back to a clean slate, from your current state:

# Stash your changes.
▸ git reset --soft 'c2baf80929062233d12524d88f31ab9bcc1f805d^'
▸ git stash
# Update to the original master's current head.
▸ git fetch https://github.com/mesonbuild/wrapdb.git
▸ git merge --ff --ff-only FETCH_HEAD
# Apply back your changes.
▸ git stash pop
# Commit and force push.

[benoit-pierre]

Sorry, should be git stash pop, not git unstash (that' s my alias for it). :P

[benoit-pierre]

Did you forget to commit your changes?

[QWERTIOX]

yup, i'm tired

[benoit-pierre]

Last push is looking good :+1:.

[jpakkane]

I enabled the tests to run, but CI does not run them for some reason. :(

[jpakkane]

I'll merge this and if something breaks we can fix it afterwards.

[eli-schwartz]

succeeded 22 minutes ago in 31s

[eli-schwartz]

I clicked the merge button about a second after you did lol