Added an option for range-v3 to build tests

[adembudak]

Added range_v3_tests build option and set it off by default.

[adembudak]

What's the advantage of the option? e.g. there aren't any external dependencies and you can restrict which tests to run by using the subproject name as a suite.

The library files are header only which doesn't need to compile, enabled tests (400+ of them) need to compiled, waiting less and spending less CPU cycles would be some of the reason i guess :)

[eli-schwartz]

The library files are header only which doesn't need to compile, enabled tests (400+ of them) need to compiled, waiting less and spending less CPU cycles would be some of the reason i guess :)

Ah right, those are still compiled by default even if the tests themselves don't run...

[adembudak]

Changed range_v3_tests to tests. Not sure whether it should be tests or test though. I chose the former but any feedback is greatly appreciated.

[benoit-pierre]

tests appears to be the more common choice:

▹ grep -wl "'test'" subprojects/packagefiles/*/meson_options.txt | wc -l
4
▹ grep -wl "'tests'" subprojects/packagefiles/*/meson_options.txt | wc -l
45

[jpakkane]

Please do not have merge commits in your branch, keep your branch up to date using rebase instead.

[adembudak]

Please do not have merge commits in your branch, keep your branch up to date using rebase instead.

Thanks, will keep it in mind next time.

[eli-schwartz]

There are two problems:

• the issue with merge commits isn't "please remember next time", but rather "we can't merge the PR until the merge commit is removed"
• the merge commit also contains significant logic changes to the range-v3 wrap, which is one of the reasons the policy exists to not merge a merge commit

P.S. Sorry for not noticing the request to review.

[eli-schwartz]

[1/479] Compiling C++ object subprojects/range-v3-0.12.0/test/action/range.v3.test.act.concepts.exe.p/cont_concepts.cpp.obj
FAILED: subprojects/range-v3-0.12.0/test/action/range.v3.test.act.concepts.exe.p/cont_concepts.cpp.obj 
"clang-cl" "-Isubprojects\range-v3-0.12.0\test\action\range.v3.test.act.concepts.exe.p" "-Isubprojects\range-v3-0.12.0\test\action" "-I..\subprojects\range-v3-0.12.0\test\action" "-I..\subprojects\range-v3-0.12.0\include" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/EHsc" "/std:c++17" "/permissive-" "/Od" "/Zi" "/Fdsubprojects\range-v3-0.12.0\test\action\range.v3.test.act.concepts.exe.p\cont_concepts.cpp.pdb" /Fosubprojects/range-v3-0.12.0/test/action/range.v3.test.act.concepts.exe.p/cont_concepts.cpp.obj "/c" ../subprojects/range-v3-0.12.0/test/action/cont_concepts.cpp
In file included from ../subprojects/range-v3-0.12.0/test/action/cont_concepts.cpp:10:
In file included from C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\array:8:
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\yvals_core.h(898,1): error: static assertion failed: error STL1000: Unexpected compiler version, expected Clang 17.0.0 or newer.
_EMIT_STL_ERROR(STL1000, "Unexpected compiler version, expected Clang 17.0.0 or newer.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\yvals_core.h(519,44): note: expanded from macro '_EMIT_STL_ERROR'
#define _EMIT_STL_ERROR(NUMBER, MESSAGE)   static_assert(false, "error " #NUMBER ": " MESSAGE)
                                           ^             ~~~~~
1 error generated.

What does this mean???

[adembudak]

[1/479] Compiling C++ object subprojects/range-v3-0.12.0/test/action/range.v3.test.act.concepts.exe.p/cont_concepts.cpp.obj
FAILED: subprojects/range-v3-0.12.0/test/action/range.v3.test.act.concepts.exe.p/cont_concepts.cpp.obj 
"clang-cl" "-Isubprojects\range-v3-0.12.0\test\action\range.v3.test.act.concepts.exe.p" "-Isubprojects\range-v3-0.12.0\test\action" "-I..\subprojects\range-v3-0.12.0\test\action" "-I..\subprojects\range-v3-0.12.0\include" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/EHsc" "/std:c++17" "/permissive-" "/Od" "/Zi" "/Fdsubprojects\range-v3-0.12.0\test\action\range.v3.test.act.concepts.exe.p\cont_concepts.cpp.pdb" /Fosubprojects/range-v3-0.12.0/test/action/range.v3.test.act.concepts.exe.p/cont_concepts.cpp.obj "/c" ../subprojects/range-v3-0.12.0/test/action/cont_concepts.cpp
In file included from ../subprojects/range-v3-0.12.0/test/action/cont_concepts.cpp:10:
In file included from C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\array:8:
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\yvals_core.h(898,1): error: static assertion failed: error STL1000: Unexpected compiler version, expected Clang 17.0.0 or newer.
_EMIT_STL_ERROR(STL1000, "Unexpected compiler version, expected Clang 17.0.0 or newer.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\yvals_core.h(519,44): note: expanded from macro '_EMIT_STL_ERROR'
#define _EMIT_STL_ERROR(NUMBER, MESSAGE)   static_assert(false, "error " #NUMBER ": " MESSAGE)
                                           ^             ~~~~~
1 error generated.

What does this mean???

Seems like something related with clang-cl version, the runner has version 16.0.6:

range-v3| Project name: range-v3
range-v3| Project version: 0.12.0
range-v3| C++ compiler for the host machine: clang-cl (clang-cl 16.0.6)

[eli-schwartz]

Aha: https://github.com/actions/runner-images/issues/10001 https://github.com/actions/runner-images/issues/10018