search

mesos / chronos

Fault tolerant job scheduler for Mesos which handles dependencies and ISO8601 based schedules
http://mesos.github.io/chronos/
Apache License 2.0
4.39k stars 528 forks source link

Add option to disable HTTP access if HTTPS is enabled #612

Open cookandy opened 8 years ago

cookandy commented 8 years ago

Similar to Marathon, we should be able to disable HTTP after enabling HTTPS.

Perhaps adding a --disable_http option would be easiest.

Similar to https://github.com/mesosphere/marathon/issues/1360

ddossot commented 8 years ago

I imagine this is not yet possible because of this code:

  def buildUrl(leaderData: String, request: HttpServletRequest) = {
    if (request.getQueryString != null) {
      new URL("http://%s%s?%s".format(leaderData, request.getRequestURI, request.getQueryString))
    } else {
      new URL("http://%s%s".format(leaderData, request.getRequestURI))
    }
  }

in the proxy-to-master filter. HTTP is hardcoded here so it can't be yet turned off when SSL is activated, otherwise slave to master proxying will fail.