Don't kill executors sending a TASK_STARTING update.

mesos / chronos

Fault tolerant job scheduler for Mesos which handles dependencies and ISO8601 based schedules

http://mesos.github.io/chronos/

Apache License 2.0

4.39k stars 529 forks source link

Don't kill executors sending a TASK_STARTING update. #854

Closed lava closed 7 years ago

lava commented 7 years ago

Since the dawn of Mesos, executors have had the option of sending a TASK_STARTING update to indicate that the launch command has been received. Currently, Chronos will react to to this update by killing the task.

As far as I can tell, this should fix the issue and tests are passing, but I will admit that I have no experience with either Scala or Maven.

gkleiman commented 7 years ago

LGTM

How did you test this? Did you try setting up a cluster with a version of Mesos that sends TASK_STARTING and checking if Chronos works fine?

Can you please open a similar PR against the stable branch?

Thanks!

gkleiman commented 7 years ago

I synced with @lava, he did some manual testing and the change works fine.