search

mesos / chronos

Fault tolerant job scheduler for Mesos which handles dependencies and ISO8601 based schedules
http://mesos.github.io/chronos/
Apache License 2.0
4.39k stars 529 forks source link

Add max completion time to taskInfo (#881) #884

Closed edi33416 closed 6 years ago

edi33416 commented 6 years ago

This cherry-picks #881 onto stable, in order to provide maxCompletionTime to version 2.x

@gkleiman can you please review?

edi33416 commented 6 years ago

Please note that I had to remove the concurrent field, as it wasn't present on stable. See errors

[ERROR] /home/fawkes/chronos/src/main/scala/org/apache/mesos/chronos/utils/JobSerializer.scala:130: error: value concurrent is not a member of org.apache.mesos.chronos.scheduler.jobs.BaseJob
[ERROR]     json.writeBoolean(baseJob.concurrent)
[ERROR] /home/fawkes/chronos/src/main/scala/org/apache/mesos/chronos/scheduler/jobs/Jobs.scala:127: error: value concurrent overrides nothing
[ERROR]                              @JsonProperty override val concurrent: Boolean = false,
[ERROR]                                                         ^                                                                                                                                                  
[ERROR] /home/fawkes/chronos/src/main/scala/org/apache/mesos/chronos/scheduler/jobs/Jobs.scala:166: error: value concurrent overrides nothing
[ERROR]                                @JsonProperty override val concurrent: Boolean = false,
[ERROR]                                                           ^
gkleiman commented 6 years ago

LGTM, thank you so much!