search

mesos / elasticsearch

Elasticsearch on Mesos
Apache License 2.0
242 stars 90 forks source link

Support for Mesos 1.0.1 #587

Open krishnabigdata opened 8 years ago

krishnabigdata commented 8 years ago

Hi ,

I have been trying to build the mesos-elasticsearch-scheduler-1.0.1.jar for mesos 1.0.1 but it fails, Please let me know does the current setup supports Mesos 1.0.1

Regards, Krishna.

rsingh2411 commented 8 years ago

Yes , this setup works on Mesos 1.0.1 , we have tested with scheduler build with mesos 0.28.2. Only change is required in CredentialFactory class getBuilder() method. thsi line of code credentialBuilder.setSecret(bytes); needs to be changed to credentialBuilder.setSecretBytes(bytes);

krishnabigdata commented 8 years ago

Thanks, it solved, I cleared all cache from gradle and re-build from the beginning.

gondor commented 8 years ago

@rsingh2411 @philwinder

Just saw this issue. We are about to upgrade our clusters from 0.28.2 to 1.0.1 of Mesos. We've been running the ES Scheduler 1.0.1 (Docker Image) in Marathon. Will that image still function on Mesos 1.0.1 or do I need to build a custom image with some code tweaks?

philwinder commented 8 years ago

@gondor @krishnabigdata @rsingh2411. The 1.0.1 version number is a coincidence. It does not correspond to a version of mesos.

I haven't tested this on anything higher than 0.28.

Thank you @rsingh2411 for providing details on how to upgrade to 1+. Would you care to make that a PR?

@gondor It sounds like there is an API change on the authorisation module. If you don't need auth, then it might continue to work. As always, test first. Let us know the outcome.

Thanks all.