search

mesos / elasticsearch

Elasticsearch on Mesos
Apache License 2.0
242 stars 92 forks source link

Ack ElasticSearch 5.0 changes regarding heap size #592

Closed nubunto closed 7 years ago

nubunto commented 7 years ago

The heap size in ElasticSearch 5.0 now come from the env var "ES_JAVA_OPTS", as opposed to the old "JAVA_OPTS". This change strives for better compatibility with other ElasticSearch versions, and acks ES_JAVA_OPTS as one of the options of setting the heap size.

containersol commented 7 years ago

Can one of the admins verify this patch?

frankscholten commented 7 years ago

LGTM

Thanks for your contrubution @nubunto!

nubunto commented 7 years ago

Since yesterday, I have found some low hanging fruit that makes this change a breaking change, @frankscholten. I'm commiting it right now, but I think that we probably want to revert this. Sorry for not picking this up earlier.

nubunto commented 7 years ago

And for full backwards compatibility, I would like to discuss a way of getting at the ES version at configuration time.

frankscholten commented 7 years ago

Ok, I reverted the commits. Let me know when we can merge again.