search

mesos / hadoop

Hadoop on Mesos
176 stars 80 forks source link

Added Framework Authentication (Issue #53). #54

Closed DarinJ closed 9 years ago

DarinJ commented 9 years ago

Modified MesosScheduler.java and configuration.md. Now mapred.mesos.framework.principal, mapred.mesos.framework.secretfile, mapred.mesos.framework.user, and mapred.mesos.framework.name are configureable options.

tarnfeld commented 9 years ago

Looks awesome, thanks for the contribution! I'll give it a whirl and merge if it looks good.

tarnfeld commented 9 years ago

Would you mind rebasing this against master? Sorry it's a pain I know!

DarinJ commented 9 years ago

No issues rebasing, but there's another PR in the queue. Which order do you want to merge them? I can probably do the rebase in the next hour, but can wait if you'd rather merge the other in first.

tarnfeld commented 9 years ago

The other PR is mine and isn't quite ready to go yet, so i'll sort that out. This one will definitely be merged first :smiley:

DarinJ commented 9 years ago

Started rebase, more merge conflicts than expected. Shouldn't be hard but don't want to rush it before a meeting expect done by EOD tomorrow.

DarinJ commented 9 years ago

@tarnfeld rebased. Tested locally to make sure the merge went fine. Cheers.

PS: If you want a maven to enforce a checkstyle I could probably add it in the next week or so.

tarnfeld commented 9 years ago

Just two teeny style comments, I think we should definitely add some tools for doing checkstyle or something like that. I'm just keen to keep the code consistent across the project at the moment.

If you fix those two things i'll merge the PR right away! Thanks again.

DarinJ commented 9 years ago

@tarnfeld you caught me at a good time. Updated and squashed commits.

I'll open an issue on checkstyles, I've got a few other things I'd like to contribute in the near future. Getting checkstyles will end up saving me time :).