mesos / kafka

Apache Kafka on Apache Mesos
Apache License 2.0
414 stars 140 forks source link

Change task and executor name to the framework name #206

Closed nicgrayson closed 8 years ago

nicgrayson commented 8 years ago

I want to be able to run multiple kafka clusters on the same mesos while using mesos-dns / mesos-consul.

The dns names for the brokers is generated from the executor name, i.e. broker-0.service.consul. This means that I need different executor names for different clusters.

I was thinking about adding a task name or task prefix value but figured this solution was good since you want to know which task goes with which framework.

As you can see I swapped out the hard coded 'broker-' value. I also needed to change the logic of pulling the broker number out of this string since a framework name could include a dash.

Let me know if you have any questions or concerns.

This is almost exactly like the change in https://github.com/elodina/exhibitor-mesos-framework/pull/53 btw