search

mesos / kafka

Apache Kafka on Apache Mesos
Apache License 2.0
414 stars 140 forks source link

Upgrade to kafka 0.10.2.0 #287

Closed shangd closed 7 years ago

shangd commented 7 years ago

In kafka 0.10.2.0, it no longer include a compile dependency on netty, so BrokerLogManager has to be updated since it was using some classes from netty to implement a timeout function. I swapped out the timeout implementation with Java's native ScheduledExecutorService so it won't need extra dependencies.

steveniemitz commented 7 years ago

Can you rebase this against master? The v10 branch is the release branch for kafka-mesos v0.10.0, not kafka 0.10.0.

LGTM otherwise though, thanks for the pull request!

steveniemitz commented 7 years ago

I rebase/merged this manually, not sure why github didn't autoclose it though.

shangd commented 7 years ago

@steveniemitz Thanks for the merge, I got a few more PR coming, I'll rebase them to master.

steveniemitz commented 7 years ago

Awesome! Looking forward to seeing them, thanks for the contributions!