added error json response for broker endpoints

mesos / kafka

Apache Kafka on Apache Mesos

Apache License 2.0

414 stars 140 forks source link

added error json response for broker endpoints #302

Open bjoel opened 7 years ago

steveniemitz commented 7 years ago

Can you comment on what this is trying to fix/improve?

bjoel commented 7 years ago

Apologies for the late reply. This commit changes the error responses within the broker endpoints to return JSON values. Currently we have a service hitting these endpoints and when something goes wrong (i.e attempting to remove a broker which is currently running) HTML is returned. It is more helpful to return JSON so that our service can interpret the response and react appropriately.

steveniemitz commented 7 years ago

Cool, seems good to me. Have you tested the backwards-compat case with an old client -> new server (and vis versa)?