search

mesos / kibana

Kibana on Mesos
Apache License 2.0
27 stars 9 forks source link

JARs from JitPack #3

Closed sadovnikov closed 8 years ago

sadovnikov commented 8 years ago

Generated on JitPack JAR is very different from locally built one. Attempts to install the framework with JAR from JitPack https://jitpack.io/com/github/mesos/kibana/_KB_VERSION_/kibana-_KB_VERSION_.jar fail with ApplicationContextException: Unable to start EmbeddedWebApplicationContext due to missing EmbeddedServletContainerFactory bean The generated on JitPack JARs are not complete

sadovnikov commented 8 years ago

Actually, I liked the way Kibana build names JARs. If there are not local changes, its adds commit ID to the jar name; if commit ID matches with tag - it adds tags instead of commit ID; if there are local changes - it adds “local” with timestamp. However this seems to be confusing for JitPack

philwinder commented 8 years ago

Fixed in #7

sadovnikov commented 8 years ago

resolved by @philwinder