search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

additional testing for zk detection #100

Open jdef opened 9 years ago

jdef commented 9 years ago

Was thinking about the implementation some more, and am concerned that the unit tests are still not adequate. for example:

vladimirvivien commented 9 years ago

@jdef with your integration of this with Kubernetes, do you still feel uncomfortable, should we revisit ?

jdef commented 9 years ago

christos had mentioned that he experienced some problems with the detector when ZK was killed and started. I tried with a single-master system (on GCE) and the mesos master died too - which I thought was strange. I haven't tested on a multi-ZK cluster yet but I wanted to start a framework and then take down all the ZK nodes, then bring them back up and see what happened. And from there, perhaps derive some additional automated tests.

jdef commented 9 years ago

additional testing:

tsenart commented 9 years ago

@jdef: Is this covered in #162?

jdef commented 9 years ago

No, but #162 may be seen as an enabler because it's MUCH thinner than the fat client shim that was there before and the interface is cleaner.

On Thu, Sep 10, 2015 at 8:33 AM, Tomás Senart notifications@github.com wrote:

@jdef https://github.com/jdef: Is this covered in #162 https://github.com/mesosphere/mesos-go/pull/162?

— Reply to this email directly or view it on GitHub https://github.com/mesosphere/mesos-go/issues/100#issuecomment-139221787 .

tsenart commented 9 years ago

This is another candidate issue to be moved to an independent github.com/mesosphere/detector