Makefile and protobuf tweaks

jdef commented 7 years ago

fix broken make protobufs
gogo customname some fields to be more idiomatic in their Golang form
revisit gogo nullable for fields that reference enum types. document current thinking
compare against latest Mesos 1.0.x tree for differences -- none found!

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 36.559% when pulling 47a79617bd954e3b360bea1015c6292f2cc1aee5 on jdef_fix_make_protobufs into 42e45a820ca7a7953c34c62c9b29b545e2275b0b on master.

jdef commented 7 years ago

fun failure w/ golang-tip:

13.83s$ make install
go install github.com/mesos/mesos-go/api/v1/cmd/example-executor github.com/mesos/mesos-go/api/v1/cmd/example-scheduler
# github.com/mesos/mesos-go/api/v1/lib/httpcli/httpsched
api/v1/lib/httpcli/httpsched/state.go:73:19: internal compiler error: cannot inline function containing closure: 
.   CLOSURE l(44) ff(1) tc(1) httpsched.maybeLogged.func1 FUNC-func(*http.Request) (*http.Response, error)

I'd really like to clean up that module anyway. Funny that golang has a problem with it

mesos / mesos-go

Makefile and protobuf tweaks #284