search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

scheduler improvements and API tweaks #286

Closed jdef closed 7 years ago

jdef commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 36.489% when pulling 70084cf010caa25454550023426d3e5f30131491 on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 36.496% when pulling 299e0effe3cf899b9fd51f57cee41d8865d2279d on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 36.442% when pulling e98a3fbae35ba152a64420d65e70c14f40ff1a6d on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 36.514% when pulling 7c4c8c7af6f946e118ada0863b6224a0938fb79b on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.002%) to 36.475% when pulling 60818dfbcbb80220812280c304c210bc3dfe0c79 on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 36.405% when pulling a8ba6d23270daef8a58f894a662b0c4fa242a284 on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 36.521% when pulling 3db5f2ccb9778eeebc21c77d35218f9cce23df01 on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 36.487% when pulling 17a0ad3ef16a139f9f6054ae347d61f961e2740c on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

jdef commented 7 years ago

upon the scheduler receiving an ERROR event, it should probably re-try subscription. unless Mesos terminates the current subscription connection after sending an ERROR (which is not in the contract) then we're still in trouble because the httpsched state doesn't know anything about these ERROR messages so it will stay "connected" (and reject SUBSCRIBE attempts)

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 36.195% when pulling a4cc120adfd5f0185003d8459a2afb0bdf86b66a on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 36.504% when pulling a4cc120adfd5f0185003d8459a2afb0bdf86b66a on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 36.519% when pulling 99f337093d93416c08d5e82fcc3f91338f0fcdee on jdef_scheduler_improvements into 43f0fa5c0be7a3d0e20a66a88b67de49b57c2337 on master.

jdef commented 7 years ago

This PR is massive enough and I'm mostly happy (enough) with it. Will keep it open for a few days for comments and merge if there are no complaints.

jdef commented 7 years ago

ideally there would be tests shipping with these changes

jdef commented 7 years ago

fixes #277

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.01%) to 36.446% when pulling 7fd41ca0fdec858b954d12de3101b300c28b9c4f on jdef_scheduler_improvements into c00d0c1ebcc9d23e8ae808448a36c347c52522ee on master.

jdef commented 7 years ago

filed ticket to track tech debt for better unit tests in httpcli and httpsched: #291