search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

API package godocs that summarize and favor the v1 API over v0 #292

Closed jdef closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 36.425% when pulling d662a591c9129e440645095c08af577f3d8d1c44 on jdef_initial_v1_package_godocs into d09f6636ea1d4f946e894321ff6d90b1f7cd15d8 on master.

pires commented 7 years ago

Just my two cents, but I don't like api/v1/lib subpackage. I'd move examples as part of the api/v1 package where possible. In case an example doesn't make sense or doesn't work following that method, move it to /examples/v1.

jdef commented 7 years ago

The examples are pretty complex. examples/{v0,v1} is something I could get behind. Though I would sort of feel bad reorganizing the repo twice in such a short time period.

jdef commented 7 years ago

proposal for (yet again) restructuring the repo: #294

pires commented 7 years ago

That's what we, software engineers, do all the time: move things around and call it fancy names like refactor, redesign, restructure. Do it 👍

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 36.49% when pulling b31688fc8476f487cfd4c1bd7286a7f6e884c0b6 on jdef_initial_v1_package_godocs into accb133e89fc773b3c866c533b56e78497cf769b on master.

jdef commented 7 years ago

committing this change to offer guidance until restructuring takes place