search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

apierrors: make response message more descriptive #303

Closed hotienvu closed 7 years ago

hotienvu commented 7 years ago

Something like malformed request: Failed to validate scheduler::Call: Expecting 'framework_id' to be present is more helpful than just "malformed request"

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 36.5% when pulling 8bd1575051711f99a79548424325b5084a138114 on hotienvu:master into fe43f9c76d1d24530cc0e024170f7ea8ebc0a29f on mesos:master.

jdef commented 7 years ago

thanks for the PR! I'd prefer a bit cleaner output if Details isn't set. How about changing to something like:

if err.Details != "" {
  return err.Message + ": " + err.Details
}
return err.Message
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 36.441% when pulling 7f8b9083cd4069fbce4cbdb582318e2f3fa94d92 on hotienvu:master into fe43f9c76d1d24530cc0e024170f7ea8ebc0a29f on mesos:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 36.445% when pulling c291914f01daef16b2d9812fe6769606714f41de on hotienvu:master into fe43f9c76d1d24530cc0e024170f7ea8ebc0a29f on mesos:master.

hotienvu commented 7 years ago

I have fixed and added tests but coverage still drops. It looks like the coverage settings need to be updated as well?

jdef commented 7 years ago

don't worry about coverage, i've got a fix for that coming