protos: upgrade to latest 1.2.x protobuf API

mesos / mesos-go

Go language bindings for Apache Mesos

Apache License 2.0

545 stars 146 forks source link

protos: upgrade to latest 1.2.x protobuf API #304

Closed jdef closed 7 years ago

jdef commented 7 years ago

update mesos protos to the latest 1.2.x v1 API
scheduler and executor API updates to correspond to proto API changes
update examples to comply with mesos 1.2.x API
patched a bug in the msh example

coveralls commented 7 years ago

Changes Unknown when pulling d959fa04c1601aab2b17c05ef7ea999f5b4d1be5 on jdef_mesos_protos_1_2_x into on master.

coveralls commented 7 years ago

Changes Unknown when pulling d959fa04c1601aab2b17c05ef7ea999f5b4d1be5 on jdef_mesos_protos_1_2_x into on master.

coveralls commented 7 years ago

Changes Unknown when pulling 6376f087bec73ad4d03093639bbe100d5c5c359b on jdef_mesos_protos_1_2_x into on master.

coveralls commented 7 years ago

Changes Unknown when pulling 57efa145f0a636f9014b2dbf9e3b08cc225236b9 on jdef_mesos_protos_1_2_x into on master.

coveralls commented 7 years ago

Changes Unknown when pulling 5b31508b5409bd0fdea6cd3e899a75ddbb589bca on jdef_mesos_protos_1_2_x into on master.

coveralls commented 7 years ago

Changes Unknown when pulling 5b31508b5409bd0fdea6cd3e899a75ddbb589bca on jdef_mesos_protos_1_2_x into on master.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 51.741% when pulling f1a05a934ddaaa46e9c75929c9456b762bac1391 on jdef_mesos_protos_1_2_x into f1c7b74877e7aefd8d61bce32685ec4c2fc691ce on master.

jdef commented 7 years ago

MESOS change for Revive/Suppress messaging: https://issues.apache.org/jira/browse/MESOS-6638

SUPPRESS and REVIVE were already members of Call.Type prior to 1.2; now that they have corresponding message object types, it's unclear if the message objects are actually required if there's no role to set. The docs are unclear on this

jdef commented 7 years ago

As per the above, message objects are NOT required for SUPPRESS and REVIVE in the 1.2 API (and a quick scan of the 1.3.x impl shows the same): https://github.com/apache/mesos/blob/1.2.x/src/master/validation.cpp#L382

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 51.741% when pulling a56b4f9b7e79a9f942112d3da9749c619f002b34 on jdef_mesos_protos_1_2_x into f1c7b74877e7aefd8d61bce32685ec4c2fc691ce on master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 52.609% when pulling 4c40945ba091190432dd68889231ede9ce2b9dcc on jdef_mesos_protos_1_2_x into f1c7b74877e7aefd8d61bce32685ec4c2fc691ce on master.