search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

Upgrade golang versioin to 1.8.1 #305

Closed keloyang closed 7 years ago

keloyang commented 7 years ago

With golang1.6.1, when 'make docker', we will encounter the following issue,

api/v1/cmd/example-executor/main.go:4:2: cannot find package "context" in any of:
        /go/src/github.com/mesos/mesos-go/api/v1/cmd/vendor/context (vendor tree)
        /go/src/github.com/mesos/mesos-go/api/v1/vendor/context
        /usr/local/go/src/context (from $GOROOT)
        /go/src/context (from $GOPATH)
Makefile:108: recipe for target 'docker' failed

This is because golang has no package "context", so upgrade golang to 1.8.1 .

Signed-off-by: Shukui Yang yangshukui@huawei.com

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling fefe5a24a0949ed416f5bb38529b196209eaba42 on keloyang:golang-1.8.1 into on mesos:master.

jdef commented 7 years ago

thanks for the PR!