jdef
commented
7 years ago make test fails for me because of some GoString related test. Suspect a bug in gogo/protobuf. I hacked the test to output the result of the GoString func that failed to parse:
--- FAIL: TestEvent_TaskUpdatedGoString (0.00s)
masterpb_test.go:7963: failed to parse &master.Event_TaskUpdated{FrameworkID: mesos.FrameworkID{Value: "CW0R6JWXGjhG3m3pAnAbJV0jG7DTCYQvCekLB5zY0FxUZa6N8JzsTMxQyffu",
},
Status: mesos.TaskStatus{TaskID: mesos.TaskID{Value: "0g2LMJZn5Nmp9rhboWMBvMfvJDMEGJ0q4UpS5tjBVCB3FuDclnFoTG3HsJH57ufYnZ3nQzz7COA4",
},
State: func(v mesos.TaskState) *mesos.TaskState { return &v } ( 5 ),
Message: func(v string) *string { return &v } ( "6G44Yqd" ),
Source: func(v mesos.TaskStatus_Source) *mesos.TaskStatus_Source { return &v } ( 1 ),
Reason: func(v mesos.TaskStatus_Reason) *mesos.TaskStatus_Reason { return &v } ( 20 ),
ExecutorID: &mesos.ExecutorID{Value: "FlRaWodJlx61RG5k3NjbS3bOFGFKiqvR4R8yWOdRMkgJNmbQ9BhtGXEIHOw",
},
Timestamp: func(v float64) *float64 { return &v } ( 0.1795823327242275 ),
Healthy: func(v bool) *bool { return &v } ( false ),
CheckStatus: &mesos.CheckStatusInfo{Type: func(v mesos.CheckInfo_Type) *mesos.CheckInfo_Type { return &v } ( 2 ),
Command: &mesos.CheckStatusInfo_Command{ExitCode: func(v int32) *int32 { return &v } ( -69695686 ),
},
HTTP: &mesos.CheckStatusInfo_Http{StatusCode: func(v uint32) *uint32 { return &v } ( 0x95f985dc ),
},
},
Labels: &mesos.Labels{Labels: []mesos.Label{mesos.Label{Key:"tBGAfISwYn3XJusiJitNyQSZlnTBg", Value:(*string)(0xc42015c600)}, mesos.Label{Key:"EiJHST1g4QWQeYDPGaCHmsPtRzq27ZMznvMLGfoQd20c9oLC5i2UqDi
mc8oPnI3nhWFvzK1ui", Value:(*string)(0xc42015c620)}, mesos.Label{Key:"qPSxKCnx1UW6uSjUkeaBkK", Value:(*string)(0xc42015c630)}, mesos.Label{Key:"tydcu0owgtFNChnDhlO95bjonwijuOkcqsBY2ZmS0rWcLdQNce8D4qWompMDeHrStSkgC
JpBKEa", Value:(*string)(0xc42015c640)}},
},
UnreachableTime: &mesos.TimeInfo{Nanoseconds: -5095539703890242531,
},
},
State: func(v master.mesos.TaskState) *master.mesos.TaskState { return &v } ( 1 ),
}
panic: 24:8: expected expression (and 3 more errors) [recovered]
panic: 24:8: expected expression (and 3 more errors)
goroutine 341 [running]:
testing.tRunner.func1(0xc42014d6c0)
/usr/local/go-1.8.1/src/testing/testing.go:622 +0x55f
panic(0xc50620, 0xc4203ff320)
/usr/local/go-1.8.1/src/runtime/panic.go:489 +0x2f0
github.com/mesos/mesos-go/api/v1/lib/master.TestEvent_TaskUpdatedGoString(0xc42014d6c0)
/home/vagrant/mesos-go-workspace/src/github.com/mesos/mesos-go/api/v1/lib/master/masterpb_test.go:7964 +0x517
testing.tRunner(0xc42014d6c0, 0xcb4db0)
/usr/local/go-1.8.1/src/testing/testing.go:657 +0x108
created by testing.(*T).Run
/usr/local/go-1.8.1/src/testing/testing.go:697 +0x544
FAIL github.com/mesos/mesos-go/api/v1/lib/master 4.348sThe (generated, then hacked) test case is:
func TestEvent_TaskUpdatedGoString(t *testing.T) {
popr := math_rand.New(math_rand.NewSource(time.Now().UnixNano()))
p := NewPopulatedEvent_TaskUpdated(popr, false)
s1 := p.GoString()
s2 := fmt.Sprintf("%#v", p)
if s1 != s2 {
t.Fatalf("GoString want %v got %v", s1, s2)
}
_, err := go_parser.ParseExpr(s1)
if err != nil {
t.Errorf("failed to parse %s", s1) // I added this to see what GoString was returning
panic(err) // fails the test
}
}
coveralls
updated 1.2.x protobufs
refactored client, encoding, httpcli, recordio packages to account for v1 protocol changes in 1.2.x
updated and enhanced examples
fixes #300, #310