search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

Add support for multiple disks resources #314

Closed everpcpc closed 6 years ago

everpcpc commented 7 years ago

Disk source should also be checked. Otherwise it will cause a mistaken resource comparison when using multiple disks.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 52.448% when pulling 8dc5789764c557ed1898b98ce94f586b01e396b9 on everpcpc:disk into 464c8d6a7d891b5f7695e6a6e78c6e3974223db4 on mesos:master.

jdef commented 7 years ago

Thanks for the PR! Would you mind fleshing out TestResources_PersistentVolumes or else writing a new unit test to exercise this new code?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 52.49% when pulling 7cdc264f7b5250b5394526b11856c3cee46dd539 on everpcpc:disk into 464c8d6a7d891b5f7695e6a6e78c6e3974223db4 on mesos:master.

everpcpc commented 7 years ago

Hi, I've put the tests in TestResources_Equivalent.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 52.51% when pulling 46ddaa4b1bf2c75dbc26ac7998d6e03a8980ed22 on everpcpc:disk into 464c8d6a7d891b5f7695e6a6e78c6e3974223db4 on mesos:master.

jdef commented 6 years ago

thanks, lgtm