search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

lib: allow ReservationInfo.Type to be nil #341

Closed ajwerner closed 6 years ago

ajwerner commented 6 years ago

This is to address incompatibility with Mesos 1.4 agent reservations as described in #340

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 58.39% when pulling 8e9f7806a573efb31588c2377fb9be2d6a5b9596 on ajwerner:andrew/allow_reservation_info_type_to_be_nil into c488712c2b5a908fc9534560386fc572c3d126bf on mesos:master.

jdef commented 6 years ago

thanks for the PR! it looks like the gogo protobuf generation tools are out-of-sync w/ the version of the gogo tooling that's been vendored by the project. please see the travis config for how to install the right version of the tooling and then please re-generate the protos.

https://github.com/mesos/mesos-go/blob/c488712c2b5a908fc9534560386fc572c3d126bf/.travis.yml#L19

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 58.39% when pulling 180ac5c299ee558a9d0a0052bfd0de5d26d5e1ad on ajwerner:andrew/allow_reservation_info_type_to_be_nil into c488712c2b5a908fc9534560386fc572c3d126bf on mesos:master.

ajwerner commented 6 years ago

Should be good to go

jdef commented 6 years ago

thanks!