search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

proto: bump to 1.7.x 8088142 #353

Closed chhsia0 closed 6 years ago

chhsia0 commented 6 years ago

Updated Mesos protos to adapt the new CREATE_DISK/DESTROY_DISK. Also added a new master call for GET_OPERATIONS, and new agent calls for GET_OPERATIONS, GROW_VOLUME and SHRINK_VOLUME. For the latter two, only agent-local volumes are supported.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.4%) to 57.798% when pulling 9ce7cf0472eea77c6605a5914267f490e90624d9 on chhsia0:bump-1.7.x-8088142 into f27edc01ca67f9b7e1b6a4ea9a1086e5372eaf0c on mesos:master.

jdef commented 6 years ago

Thanks for the PR! I've been trying to bump a bit more incrementally, for example if master is currently on 1.5.x then the next bump might be to the protos of the latest 1.6.x release. And a subsequent bump would bring master to 1.7.x protos. This allows for anyone consuming this library to pick a version of the protos that more closely matches the mesos release that they're currently running with.

Also, I've been trying to tag master appropriately prior to landing proto bumps from subsequent mesos minor versions. For example, before landing bumps for 1.6.x I'd tag master to indicate that it's compatible with mesos 1.5.x; and probably assign some mesos-go minor version tag as well. Once tagged, then I'd land the 1.6.x proto bump.

Does that make sense? I understand that it creates a bit more work when things fall behind here: multiple bump steps are required in such cases.

jdef commented 6 years ago

... otherwise the changes look great!

jdef commented 6 years ago

Please rebase this now that the 1.6.x protos have landed on master, thanks!